Sync QML module padding to reflect system setting pages
ClosedPublic

Authored by davidedmundson on Tue, Feb 5, 12:00 AM.

Details

Summary

In systemsettings 6a9df821ecfaa008206a260b20f595136e254821 it was
determined that the QML KCMs should do their own padding for some
reason.

QML KCMs now do this to match what's expected in system settings.

This change was not mirrored in KMultiDialog (and hence kcmshell5)

Populating d->modules had to move in order to make sure this was
available when the first page was added.

Test Plan

Ran kcmshell5 autostart (a qwidgets module) main frame still matched
where the buttons are
Ran kcmsheel5 lookandfeel (a qtquick module) main frame now matches
where the buttons are

Diff Detail

Repository
R295 KCMUtils
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Tue, Feb 5, 12:00 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptTue, Feb 5, 12:00 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
davidedmundson requested review of this revision.Tue, Feb 5, 12:00 AM
davidedmundson edited the test plan for this revision. (Show Details)Tue, Feb 5, 12:18 AM
vpilo added a subscriber: vpilo.EditedThu, Feb 7, 2:16 PM

Works for me on KCMShell and SystemSettings.

broulik added a subscriber: broulik.Fri, Feb 8, 9:26 AM

If you open multiple KCMs switching between QML- and Widget-ones leads to awkward outside margin changes with this patch.

kcmshell5 icons style

Switch between the two and observe how the sidebar dances (this is likely the same issue as when doing the same in System Settings in Icons mode rather than Sidebar)

vpilo added a comment.Fri, Feb 8, 10:22 AM

If you open multiple KCMs switching between QML- and Widget-ones leads to awkward outside margin changes with this patch.

kcmshell5 icons style

Switch between the two and observe how the sidebar dances (this is likely the same issue as when doing the same in System Settings in Icons mode rather than Sidebar)

I didn't realize you could open multiple KCMs. With that, it's much easier for me to see that there's multiple differences between QML- and Widget- based KCMs. Disabling window decoration borders, it's even more visible.

davidedmundson edited the summary of this revision. (Show Details)
davidedmundson edited the test plan for this revision. (Show Details)

update

remove hardcoded value

Running kcmshell5 icons style was a good suggestion.

We have to change an internal layout and only one of the edges - which leads to this monstrosity :/

broulik accepted this revision.Fri, Feb 8, 12:12 PM
This revision is now accepted and ready to land.Fri, Feb 8, 12:12 PM
zzag added a subscriber: zzag.Fri, Feb 8, 12:19 PM
zzag added inline comments.
src/kcmultidialog.cpp
42–43

It looks like includes are sorted. Maybe keep it that way?

This revision was automatically updated to reflect the committed changes.