With software rendering, use outlines instead of shadows on login & lock screen
ClosedPublic

Authored by ngraham on Feb 4 2019, 6:56 PM.

Details

Summary

QML shadows aren't supported with software rendering, so the white text often has poor readability.

This patch falls back to outlines when using software rendering to ensure adequate readability.

BUG: 398317
FIXED-IN: 5.15.0

Test Plan

No visual change with hardware rendering of some sort.

When forcing software rendering, I get outlines instead of shadows

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Feb 4 2019, 6:56 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 4 2019, 6:56 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Feb 4 2019, 6:56 PM
ngraham updated this revision to Diff 50874.Feb 4 2019, 6:57 PM

Use a more descriptive variable name

davidedmundson accepted this revision.Feb 4 2019, 7:11 PM
This revision is now accepted and ready to land.Feb 4 2019, 7:11 PM
This revision was automatically updated to reflect the committed changes.

FWIW, currently it'll only affect the lock screen as SDDM doesn't have any code (yet!) to enable software rendering.

Ah, well at least this part of the support is already done then! :)