Use breeze icons for search providers
AbandonedPublic

Authored by shubham on Feb 4 2019, 5:31 PM.

Details

Reviewers
ngraham
cfeck
Group Reviewers
VDG
Frameworks
Summary

Previously all the search providers had same default icon, now all have their own Breeze icon

Test Plan
  1. Open any document
  2. Choose Selection and select some area of the document
  3. Context menu appears. Go on search for ...
  4. New icons

Before:


After:

Diff Detail

Repository
R223 Okular
Branch
clipboard
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 7870
Build 7888: arc lint + arc unit
shubham created this revision.Feb 4 2019, 5:31 PM
Restricted Application added a project: Okular. · View Herald TranscriptFeb 4 2019, 5:31 PM
Restricted Application added a subscriber: okular-devel. · View Herald Transcript
shubham requested review of this revision.Feb 4 2019, 5:31 PM
shubham updated this revision to Diff 50863.Feb 4 2019, 5:33 PM

Remove comment

shubham updated this revision to Diff 50864.Feb 4 2019, 5:34 PM

Add new line

shubham added a reviewer: VDG.Feb 4 2019, 5:34 PM
shubham added a project: VDG.
shubham edited the test plan for this revision. (Show Details)
shubham added a subscriber: VDG.

Hmm, while this is a visual improvement for those particular search providers in Okular, it feels like the data model itself should be responsible for knowing its own icon, or a Breeze-friendly version of it.

shubham added a comment.EditedFeb 4 2019, 6:15 PM

@ngraham I had a look at KuriFilterData in frameworks, iconNameForPreferredSearchProvider() function is producing same icon name for all the entries ie. "text-html"

@ngraham I had a look at KuriFilter in frameworks, iconNameForPreferredSearchProvider() function is producing same icon name for all the entries.

That's probably where we should fix this, then.

broulik added a subscriber: broulik.Feb 5 2019, 8:36 AM

Yeah -1, filterData.iconNameForPreferredSearchProvider should give us a proper icon.

https://cgit.kde.org/kio.git/tree/src/urifilters/ikws/searchproviders perhaps needs to have icons added

@broulik Adding icons to the .desktop files does not work, I tried.

broulik added a comment.EditedFeb 5 2019, 11:37 AM

Check out D18755

Then you can put Icon=foo in the respective search provider desktop file

shubham abandoned this revision.Feb 5 2019, 2:16 PM

Abandoned in favour of D18761