Previously all the search providers had same default icon, now all have their own Breeze icon
Details
Details
- Reviewers
ngraham cfeck - Group Reviewers
VDG Frameworks
- Open any document
- Choose Selection and select some area of the document
- Context menu appears. Go on search for ...
- New icons
Before:
After:
Diff Detail
Diff Detail
- Repository
- R223 Okular
- Branch
- clipboard
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 7870 Build 7888: arc lint + arc unit
Comment Actions
Hmm, while this is a visual improvement for those particular search providers in Okular, it feels like the data model itself should be responsible for knowing its own icon, or a Breeze-friendly version of it.
Comment Actions
@ngraham I had a look at KuriFilterData in frameworks, iconNameForPreferredSearchProvider() function is producing same icon name for all the entries ie. "text-html"
Comment Actions
Yeah -1, filterData.iconNameForPreferredSearchProvider should give us a proper icon.
https://cgit.kde.org/kio.git/tree/src/urifilters/ikws/searchproviders perhaps needs to have icons added
Comment Actions
Check out D18755
Then you can put Icon=foo in the respective search provider desktop file