Differential D18728

[kcmkwin] Properly load effects
ClosedPublic
Actions

Authored by zzag on Feb 4 2019, 4:09 PM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Commits
R108:56b24f959f0b: [kcmkwin] Properly load effects
Summary

EffectsModel has to communicate with KWin in order to receive the
actual value of SupportedRole. So, in theory the model should notify
about loaded effects after receiving response from KWin, but that's
not the case.

Test Plan

Desktop Effects KCM no longer flashes when resetting changes.

Diff Detail

Repository
R108 KWin
Branch
split-desktop-effects-kcm
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 7866
Build 7884: arc lint + arc unit
zzag created this revision.Feb 4 2019, 4:09 PM
Restricted Application added a project: KWin. · View Herald TranscriptFeb 4 2019, 4:09 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Feb 4 2019, 4:09 PM
zzag edited the summary of this revision. (Show Details)Feb 4 2019, 4:17 PM
zzag updated this revision to Diff 50861.Feb 4 2019, 4:33 PM

edit comment

zzag updated this revision to Diff 50893.Feb 4 2019, 9:17 PM

Rebase.

davidedmundson accepted this revision.Feb 5 2019, 9:33 AM
This revision is now accepted and ready to land.Feb 5 2019, 9:33 AM
Closed by commit R108:56b24f959f0b: [kcmkwin] Properly load effects (authored by zzag). · Explain WhyMar 18 2019, 11:42 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 50860

View Options

kcmkwin/common/effectsmodel.h

Loading...
View Options

kcmkwin/common/effectsmodel.cpp

Loading...
View Options

kcmkwin/kwindesktop/animationsmodel.cpp

Loading...