Differential D18727

[Icon Applet] Use libTaskManager for startup feedback
ClosedPublic
Actions

Authored by broulik on Feb 4 2019, 4:01 PM.

Details

Reviewers
hein
Group Reviewers
Plasma
Commits
R120:4c211cbf885a: [Icon Applet] Use libTaskManager for startup feedback
Summary

Makes it future-proof for Wayland

Test Plan

(and Eike happy)

  • still works the same

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Feb 4 2019, 4:01 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 4 2019, 4:01 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Feb 4 2019, 4:01 PM
hein accepted this revision.Feb 4 2019, 4:46 PM

❤

This revision is now accepted and ready to land.Feb 4 2019, 4:46 PM
davidedmundson added a subscriber: davidedmundson.Feb 4 2019, 6:43 PM
davidedmundson added inline comments.
applets/icon/iconapplet.cpp
404

should this be index(i, 0) ?

broulik added inline comments.Feb 4 2019, 7:43 PM
applets/icon/iconapplet.cpp
404

Good spot, indeed

Closed by commit R120:4c211cbf885a: [Icon Applet] Use libTaskManager for startup feedback (authored by broulik). · Explain WhyFeb 4 2019, 7:46 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 50880

View Options

applets/icon/CMakeLists.txt

Loading...
View Options

applets/icon/iconapplet.h

Loading...
View Options

applets/icon/iconapplet.cpp

Loading...