Differential D18714

Add some Maxima constans and function
ClosedPublic
Actions

Authored by sirgienko on Feb 3 2019, 8:33 PM.

Details

Reviewers
dhaumann
Group Reviewers
Framework: Syntax Highlighting
Commits
R216:a4f7f3def978: Add some Maxima constans and function

Diff Detail

Repository
R216 Syntax Highlighting
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 7838
Build 7856: arc lint + arc unit
sirgienko created this revision.Feb 3 2019, 8:33 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptFeb 3 2019, 8:33 PM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
sirgienko requested review of this revision.Feb 3 2019, 8:33 PM
sirgienko updated this revision to Diff 50807.Feb 3 2019, 8:37 PM

Add Maxima function

sirgienko retitled this revision from Add some Maxima constans to MaximaVariable list to Add some Maxima constans and function.Feb 3 2019, 8:37 PM
dhaumann accepted this revision.Feb 3 2019, 9:34 PM
dhaumann added a subscriber: dhaumann.

Looks good to me, the only missing part is to increase thw "version" number each time a highlighting file is changed.

This revision is now accepted and ready to land.Feb 3 2019, 9:34 PM
sirgienko updated this revision to Diff 50809.Feb 3 2019, 9:38 PM

Increase version

sirgienko added a comment.Feb 3 2019, 9:39 PM

Should I land it via arc? Or mannualy commit it (for short commit message)?

dhaumann added a comment.Feb 4 2019, 5:42 PM

In your branch, you should type: arc land
This will merge your branch to master and commit/push your changes, and close this revision. This only works, if you have commit access. If not, we'll take care of this for now.

sirgienko closed this revision.Feb 4 2019, 5:52 PM

Revision Contents
Changeset List

PathPackages
Mdata/syntax/maxima.xml (15 lines)

Diff 50809

View Options

data/syntax/maxima.xml

Loading...