Simplify AggregatedFetchScope code, removing all setters.
ClosedPublic

Authored by dfaure on Feb 3 2019, 7:45 PM.

Details

Summary

The naming was confusing (those were not setters but a counter
increase/decrease -- if you call a setter with the same value twice, you
expect the second call to be a no-op), and they were used from a single
place anyway.

Also remove unused methods (add/remove).

Test Plan

notificationmanagertest and aggregatedfetchscopetest still pass

Diff Detail

Repository
R165 Akonadi
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dfaure requested review of this revision.Feb 3 2019, 7:45 PM
dfaure created this revision.
dfaure updated this revision to Diff 50800.Feb 3 2019, 7:47 PM

remove another pair of add/remove methods

dvratil accepted this revision.Feb 5 2019, 12:08 PM

Nice!

This revision is now accepted and ready to land.Feb 5 2019, 12:08 PM
This revision was automatically updated to reflect the committed changes.
Restricted Application added a project: KDE PIM. · View Herald TranscriptFeb 5 2019, 8:26 PM