Differential D18701

[Icon Applet] Show busy indicator when launching app
ClosedPublic
Actions

Authored by broulik on Feb 3 2019, 4:44 PM.

Details

Reviewers
ngraham
Group Reviewers
Plasma
Commits
R120:ac3fa8cbee19: [Icon Applet] Show busy indicator when launching app
Summary

Provides some feedback when clicking the icon.

Test Plan

Placed a Dolphin icon plasmoid in my panel, clicked it, got a busy indicator while it was launching.
Same on desktop. Same for some other apps.

It doesn't work for jump list actions because they are ran by commandline rather than actual desktop file.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Feb 3 2019, 4:44 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 3 2019, 4:44 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Feb 3 2019, 4:44 PM
broulik planned changes to this revision.Feb 3 2019, 4:48 PM

Needs to set a timeout

broulik updated this revision to Diff 50819.Feb 4 2019, 8:37 AM
  • Read timeout
ngraham accepted this revision.Feb 4 2019, 2:06 PM
This revision is now accepted and ready to land.Feb 4 2019, 2:06 PM
Closed by commit R120:ac3fa8cbee19: [Icon Applet] Show busy indicator when launching app (authored by broulik). · Explain WhyFeb 4 2019, 2:10 PM
This revision was automatically updated to reflect the committed changes.
hein added a subscriber: hein.Feb 4 2019, 3:43 PM

Hmm ... I guess it's OK, but using libtaskmanager would have been nicer maybe (centralized the timeout behavior, and the monitoring).

Revision Contents
Changeset List

Diff 50847

View Options

applets/icon/CMakeLists.txt

Loading...
View Options

applets/icon/iconapplet.h

Loading...
View Options

applets/icon/iconapplet.cpp

Loading...