Update `libdbusmenuqt` and the AppMenu plugin
Needs ReviewPublic

Authored by ntninja on Feb 3 2019, 2:42 PM.

Details

Reviewers
Zren
majohnson
Summary

What the title says, synchronize the relevant bits of source code with upstream (plasma-workspace).

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
ntninja created this revision.Feb 3 2019, 2:42 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 3 2019, 2:42 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ntninja requested review of this revision.Feb 3 2019, 2:42 PM
Zren added inline comments.Feb 5 2019, 5:08 AM
plugin/libdbusmenuqt/CMakeLists.txt
27 ↗(On Diff #50770)

We do not bundle the libdbusmenuqt test directory in this repo. So you need to comment this line out otherwise it will not build with the test directory missing.

cfeck added a subscriber: cfeck.Feb 5 2019, 12:11 PM

If this fixes bug 401725, please add a line "BUG: 401725" to the commit message.

ntninja updated this revision to Diff 50993.Feb 5 2019, 9:13 PM

@Zren: Updated! Thanks for pointing this out!

@cfeck: It contains the fix from bug 399975 yes, but I don't know whether it will fix LyX.