Fix aggregation logic for cacheOnly and ignoreErrors.
ClosedPublic
Actions

Authored by dfaure on Feb 2 2019, 3:14 PM.

Details

Reviewers

Commits

R165:a646904587fc: Fix aggregation logic for cacheOnly and ignoreErrors.

Summary

Add unittests for AggregatedFetch*Scope.
They show that subscribers really need to better clean up after
themselves when unregistering, that's for the next commit (this test is too
low-level for that).

Test Plan

new test

Diff Detail

Repository

R165 Akonadi

Branch

lowleveltest (branched from Applications/18.12)

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 7780
Build 7798: arc lint + arc unit

dfaure created this revision.Feb 2 2019, 3:14 PM

Restricted Application added a project: KDE PIM. · View Herald TranscriptFeb 2 2019, 3:14 PM

dfaure requested review of this revision.Feb 2 2019, 3:14 PM

Harbormaster completed remote builds in B7780: Diff 50716.Feb 2 2019, 3:14 PM

dvratil accepted this revision.Feb 2 2019, 5:00 PM

This revision is now accepted and ready to land.Feb 2 2019, 5:00 PM

dfaure closed this revision.Feb 2 2019, 5:10 PM

Revision Contents
Changeset List

		Path
M		autotests/server/CMakeLists.txt (1 line)
A	M	autotests/server/aggregatedfetchscopetest.cpp (163 lines)
M		src/server/aggregatedfetchscope.h (3 lines)
M		src/server/aggregatedfetchscope.cpp (15 lines)
M		src/server/notificationsubscriber.cpp (4 lines)