[Calendar Applet] Show day or week number in icon
ClosedPublic
Actions

Authored by broulik on Jun 14 2016, 12:46 PM.

Details

Reviewers

Group Reviewers

Plasma: Design
Plasma

Commits

Summary

Rather than showing the generic calendar icon the day number is shown there instead.
There is also an option to have it show the week number instead.

FIXED-IN: 5.7.0
BUG: 343467

Test Plan

All this effort with the singleton type just because JS Date is stupid and doesn't have a weeknumber property.

Repository

R120 Plasma Workspace

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

broulik retitled this revision from to [Calendar Applet] Show day or week number in icon.

broulik updated this object.

broulik edited the test plan for this revision. (Show Details)

broulik set the repository for this revision to R120 Plasma Workspace.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

Might need a new icon though

Where did you take that icon from?
We have apps/office-calendar and org.kde.plasma.calendar, both of which look quite different from this one.

That icon has been shipped, but never used, with the calendar applet for so long I don't even find a trace of it being added in git log.

It's plasma-workspace/applets/calendar/package/contents/images/mini-calendar.svgz

mart added a reviewer: mart.

mart added a subscriber: mart.

mart added inline comments.

applets/calendar/plugin/calendarplugin.h
37 ↗	(On Diff #4454)	i would prefer to have a c++ calendar applet instead of having more private qml imports, that i would like to completely get rid of eventually.

This revision is now accepted and ready to land.Jun 15 2016, 10:04 AM

Use a C++ applet instead of a private import

Fix cmake to include calendar subdir instead of installing

This revision was automatically updated to reflect the committed changes.

		Path
M		applets/CMakeLists.txt (2 lines)
A	M	applets/calendar/CMakeLists.txt (14 lines)
P		applets/calendar/calendarapplet.h (34 lines) Copied from applets/calendar/contents/config/config.qml
P		applets/calendar/calendarapplet.cpp (38 lines) Copied from applets/calendar/contents/ui/configGeneral.qml
P		applets/calendar/contents/config/config.qml Deleted after being copied to multiple locations: applets/calendar/calendarapplet.h applets/calendar/package/contents/config/config.qml
V		applets/calendar/{ → package}/contents/config/main.xml
V		applets/calendar/{ → package}/contents/images/mini-calendar.svgz
V		applets/calendar/{ → package}/contents/ui/configAgenda.qml
P		applets/calendar/contents/ui/configGeneral.qml Deleted after being copied to multiple locations: applets/calendar/calendarapplet.cpp applets/calendar/package/contents/ui/configGeneral.qml
V		applets/calendar/{ → package}/contents/ui/main.qml
V		applets/calendar/{ → package}/metadata.desktop
V		applets/calendar/{package ← }/contents/config/config.qml
V		applets/calendar/{package ← }/contents/config/main.xml (3 lines)
V		applets/calendar/{package ← }/contents/images/mini-calendar.svgz
V		applets/calendar/{package ← }/contents/ui/configAgenda.qml
V		applets/calendar/{package ← }/contents/ui/configGeneral.qml (31 lines)
V		applets/calendar/{package ← }/contents/ui/main.qml (50 lines)
V		applets/calendar/{package ← }/metadata.desktop

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	4454			Jun 14 2016, 12:44 PM	★	★
Diff 2	4501			Jun 15 2016, 12:48 PM	★	★
Diff 3	4503			Jun 15 2016, 12:54 PM	★	★
Diff 4	4504	cec700f	rPLASMAWORKSPACE857c0680f5c801f98f182a209f3aef02255dda83	Jun 15 2016, 12:58 PM	★	★