Differential D18654

[fonts:/ KIO] Implement stat() call
Changes PlannedPublic
Actions

Authored by broulik on Feb 1 2019, 9:08 PM.

Details

Reviewers
dfaure
ngraham
Group Reviewers
Plasma
Summary

Needed for thumbnailer to work.

BUG: 234754
FIXED-IN: 5.16.0

Test Plan

Depends on D18653
Basically just moved the special case from get to stat, keeping the coding style. Possible that I now create a temporary file instead since the thumbnailer will still get and now hit the path where it generates a ZIP that cannot be previewed. Probably needs some rethinking but I don't want to open Pandora's box by poking this stuff too hard :)

I now get thumbnails in fonts:/ "folder". Opening fonts is still not possible, gives a different error now, but no regression there..

Diff Detail

Repository
R119 Plasma Desktop
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Feb 1 2019, 9:08 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 1 2019, 9:08 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Feb 1 2019, 9:08 PM
ngraham accepted this revision.Feb 2 2019, 3:23 AM
ngraham added a subscriber: ngraham.

Nice, it works great! Original coding style is kinda funky, but this seems sane enough.

This revision is now accepted and ready to land.Feb 2 2019, 3:23 AM
broulik planned changes to this revision.Feb 4 2019, 8:49 AM

It breaks with composite fonts that are turned into a ZIP file. I had this working at one point but can't remember what I did :)

Revision Contents
Changeset List

Diff 50672

View Options

kcms/kfontinst/kio/KioFonts.h

Loading...
View Options

kcms/kfontinst/kio/KioFonts.cpp

Loading...