Improve weather-storm-* icons
ClosedPublic

Authored by ngraham on Feb 1 2019, 8:51 PM.

Details

Summary

Current icons are a bit too visually busy and cluttered. This patch corrects that by removing the background cloud and slightly resizing and repositioning the sun and moon.

BUG: 403830
FIXED-IN: 5.55

Test Plan

Before:


After:

Diff Detail

Repository
R266 Breeze Icons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Feb 1 2019, 8:51 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 1 2019, 8:51 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ngraham requested review of this revision.Feb 1 2019, 8:51 PM
ngraham edited the summary of this revision. (Show Details)Feb 1 2019, 8:51 PM

This patch corrects that by removing the background cloud

Thanks for the proposal. Hm, removal of the second cloud not what I would have expected to be done, was actually fine with it. Not sure.

slightly resizing and repositioning the sun and moon.

The current icons with sun/moon & cloud have the same size & position of the sun/moon. Changing that just for these 2 icons makes the icon set a bit more inconsistent, so if asked I would like that change to be done for all or not. Actually I am already a bit unhappy about the cloudless icons having a bigger sun/moon, that looks strange e.g. in the forecast to me.

Good point, I'll revert the sun/moon size+position changes.

ngraham updated this revision to Diff 50674.Feb 1 2019, 9:19 PM

Revert size + position changes for the sun and moon

ngraham edited the test plan for this revision. (Show Details)Feb 1 2019, 9:23 PM
ndavis requested changes to this revision.Feb 1 2019, 11:43 PM
ndavis added a subscriber: ndavis.

Certainly an improvement, you just need to strip out all of the unnecessary Inkscape metadata. You can do that with, SVG Cleaner, SVGO, or go to "File->Save As" and save as a "Plain SVG". Using an SVG optimizer is preferable because it saves a tangible amount of space when other icons are also optimized.

This revision now requires changes to proceed.Feb 1 2019, 11:43 PM
ngraham updated this revision to Diff 50689.Feb 2 2019, 3:30 AM

Optimize SVGs

ndavis accepted this revision.Feb 2 2019, 3:44 AM
This revision is now accepted and ready to land.Feb 2 2019, 3:44 AM
This revision was automatically updated to reflect the committed changes.