This allows to disable icon tinting through setting tint color to transparent.
In the current master I get file:///home/lemourin/.qt/5.12.1/gcc_64/qml/org/kde/kirigami.2/private/GlobalDrawerActionItem.qml:39:5: Unable to assign [undefined] to QColor
(probably related to some other change).
Anyway, tinting can be disabled now after your change.
I think i'll introduce an heuristic to analyze the image and decide if it's monochrome and drop all this transparent nonsense (would make it a bit inefficient as it wuld need to read pixels colors in software but may be justified).
locally i was trying with Shannon entropy of the distribution of either colors or gray values, which seems to yeld satisfying results
This commit broke my app. It is too big for me to find a bug in there.
The app in question is available here: https://github.com/lemourin/libcloudstorage/blob/master/bin/cloudbrowser/qml/main.qml
After this commit pages and toolbar don't appear at all; the only thing that's working is the drawer.
For now I'm sticking with my fork https://github.com/lemourin/kirigami/commits/master which basically means that
I can't answer your question.
when things break, pleast scream to me :) (and in general, bug report + note it on the chat is useful)
I've tried to build that app, tough cloudbrowser doesn't seem to be built/installed (if i run make in the cloudbrowser folder it says:
/bin/sh: -o: command not found
what should i look into to have it built/working?
Sorry for not creating a bug report..
Your build issue might be caused by pkg-config not being able to find moc.
You might have to set PKG_CONFIG_LIBDIR / PKG_CONFIG_PATH accordingly.
Here is the logic for detecting where moc is: https://github.com/lemourin/libcloudstorage/blob/master/configure.ac#L187
It works when I set PKG_CONFIG_LIBDIR=/home/lemourin/.qt/5.12.1/gcc_64/lib/pkgconfig:/usr/local/lib/pkgconfig:/usr/lib/pkgconfig:/usr/lib/x86_64-linux-gnu/pkgconfig:/usr/share/pkgconfig
I have qt installed from qt website through their maintenance tool.
You might find this useful: https://github.com/lemourin/libcloudstorage/blob/master/packaging/appimage/create-appimage.sh#L53
I suggest running make in the root of your build directory.
I tried to add every single path in the system where there is pkgconfig stuff, but same result, the cloudbrowser folder doesn't get built and there is the invalid command -o message still