Differential D18634

Fix AkonadiStorageTest::shouldNotifyTagAdded() flakiness.
ClosedPublic
Actions

Authored by dfaure on Jan 31 2019, 9:25 PM.

Details

Reviewers
ervin
Commits
R4:bbc3ec44fed5: Fix AkonadiStorageTest::shouldNotifyTagAdded() flakiness.
Summary

On akonadiserver side, if NotificationSubscriber::modifySubscription
happens before NotificationCollector::tagNotification, everything works.
But if it happens the other way around, the notification comes with no
attributes (therefore no "display name").

This solution is the same as what TagTest::testMonitor() in akonadi/autotests/libs/tagtest.cpp

Test Plan

ctest -R tests-units-akonadi-akonadistoragetest |& less
(and look for shouldNotifyTagAdded)

Diff Detail

Repository
R4 Zanshin
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 7733
Build 7751: arc lint + arc unit
dfaure requested review of this revision.Jan 31 2019, 9:25 PM
dfaure created this revision.
ervin accepted this revision.Feb 1 2019, 7:07 AM
This revision is now accepted and ready to land.Feb 1 2019, 7:07 AM
dfaure closed this revision.Feb 2 2019, 10:55 AM

Revision Contents
Changeset List

Diff 50621

View Options

tests/units/akonadi/akonadistoragetest.cpp

Loading...