Using replace for DesktopProtocol::prepareUDSEntry(), as we have
no guarantee that certain fields are not set elsewhere in the call chain
Details
Details
- Reviewers
chinmoyr - Group Reviewers
Plasma - Commits
- R120:bcddc7924684: Port away from deprecated KIO::UDSEntry::insert()
Both kio-slave still work
Diff Detail
Diff Detail
- Repository
- R120 Plasma Workspace
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| kioslave/desktop/kio_desktop.cpp | ||
|---|---|---|
| 183 | A doubt, why are you using replace here? Is UDS_TARGET_URL set somewhere before coming here? | |
| kioslave/desktop/kio_desktop.cpp | ||
|---|---|---|
| 183 | My bad! I didn't read the summary properly. But it seems UDS_TARGET_URL is not set anywhere prior to this (a year ago I think I fixed a bug involving this line and UDS_TARGET_URL wasn't set at that time :- ). | |
| kioslave/desktop/kio_desktop.cpp | ||
|---|---|---|
| 183 | :) Well, I would rather be safe then sorry. We have no control over what other code might do to the entry object, also is there nothing noted in any API contracts. | |