Recent released versions of libappimage set working imported cmake target,
and people better use the latest versions of libappimage anyway,
being a young & active project. No old widespread versions aronud
which need supporting here.
Details
Details
Appimage thumbnailer still builds and links (clean new build).
Diff Detail
Diff Detail
- Repository
- R320 KIO Extras
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Even with the chances being low of a system having an old version, I'd say it's better to actually make find_package look for at least the version that introduced the import target.
other than that 👍
Comment Actions
Good idea, will add.
Hm, actually, I just tried to add this and found, libappimage misses to set the version in the cmake config file, even in the latest currently released version 0.1.7.. Meh... will poke the developers to get this fixed in a new version released ASAP.
Comment Actions
Created https://github.com/AppImage/libappimage/pull/71 as one approach to get this solved on libappimage side.
Comment Actions
Use 0.1.10 as min version for libappimage, which is the first to provide
working cmake config files