When there is only one screen available the "Current Screen" and "Full Screen (All monitors)" options are identical, so this patch removes the latter.
Details
- Reviewers
ngraham - Group Reviewers
Spectacle - Commits
- R166:d71a7a505059: Remove "Full Screen(All Monitors)" when only one monitor exists
Diff Detail
- Repository
- R166 Spectacle
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
+1 on the idea.
I think it's a bit awkward that when having one screen the remaining option is "Current Screen". I think it should be "Full Screen" instead
Hmm, that's not quite what I meant. When there's only one screen, return {FullScreen, ActiveWindow, WindowUnderCursor, TransientWithParent, RectangularRegion} on X11 and {FullScreen, WindowUnderCursor, TransientWithParent} on Wayland.
In other words, CurrentScreen is the thing that should only appear when there's more than one screen.
Ah, thought you and @nicolasfella meant to change the wording on the "Current Screen" option. Isn't it a bit awkward to have "Full Screen (All monitors)" when there is just one active though? Ideally, "Current Screen" could be changed to "Full Screen" when there is only 1 monitor and left as is when there's more than one.
Just because "All monitors" looks a bit awkward when there's only 1, however its fine with me either way, I have no strong feelings on the matter.
Oh I see what you mean.
Could we instead change it so that " (All Monitors)" is only appended to the string "Full Screen" when there are are fact more then one monitor?
src/Gui/KSWidget.cpp | ||
---|---|---|
57 | Everywhere else it is QApplication::screens().count(). length() looks like we are summing lengths of all screens :P |
src/Gui/KSWidget.cpp | ||
---|---|---|
57 |