Remove break statement after return call
ClosedPublic

Authored by andreagenor on Jan 29 2019, 6:19 PM.

Details

Summary

Removes the warning: break will never be executed

Diff Detail

Repository
R374 KolourPaint
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
andreagenor requested review of this revision.Jan 29 2019, 6:19 PM
andreagenor created this revision.

I agree with the change, specially that now there's a warning on implicit falltrougth

cursors/kpCursorLightCross.cpp
69–70

I would remove the default here and leave the Transparent:

tcanabrava accepted this revision.Jan 30 2019, 8:07 AM
This revision is now accepted and ready to land.Jan 30 2019, 8:07 AM
andreagenor updated this revision to Diff 50768.Feb 3 2019, 1:57 PM
  • Remove the default case and leave transparent one
This revision was automatically updated to reflect the committed changes.