Differential D18586

Fix Failed Sprinter Test by capturing temperature with or with out decimal
ClosedPublic
Actions

Authored by rizzitello on Jan 28 2019, 4:16 PM.

Details

Reviewers
patrickelectric
laysrodrigues
tcanabrava
Commits
R232:4442d3d7f03e: Fix Failed Sprinter Test by capturing temperature with or with out decimal
R232:f28cb17b8ae3: Fix Failed Sprinter Test by capturing temperature with or with out decimal
Summary

we were failing our sprinter test

Test Plan

Run Temperature Tests

Diff Detail

Repository
R232 AtCore
Branch
fixFailedTempTest
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 7633
Build 7651: arc lint + arc unit
rizzitello requested review of this revision.Jan 28 2019, 4:16 PM
rizzitello created this revision.
rizzitello edited the test plan for this revision. (Show Details)Jan 28 2019, 4:17 PM
rizzitello added reviewers: patrickelectric, laysrodrigues, tcanabrava.
rizzitello added a project: Atelier: AtCore.
rizzitello added a subscriber: Atelier: AtCore.
tcanabrava accepted this revision.Jan 30 2019, 8:07 AM
This revision is now accepted and ready to land.Jan 30 2019, 8:07 AM
patrickelectric added inline comments.Feb 3 2019, 1:53 PM
src/core/temperature.cpp
57

Can we put examples of this both regex ?

rizzitello updated this revision to Diff 50788.Feb 3 2019, 5:10 PM
  • Add examples of regex captures
rizzitello marked an inline comment as done.Feb 3 2019, 5:10 PM
patrickelectric accepted this revision.Feb 10 2019, 3:21 PM
rizzitello closed this revision.Feb 10 2019, 4:00 PM

Revision Contents
Changeset List

PathPackages
Msrc/core/temperature.cpp (4 lines)

Diff 50440

View Options

src/core/temperature.cpp

Loading...