QStringLiteral cannot deal with duplicates, so each invokation in
the same file with the same string will create a different UTF-16
string representation for that thing. Considering that we called
the same string six times in the same function, just create a temporary
variable that's the UTF-16 representation of the QString, and use it
Details
Details
- Reviewers
apol - Commits
- R106:91b1f7115bf3: Reduce string objects
Diff Detail
Diff Detail
- Repository
- R106 KSysguard
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Looks okay from a theoretical point of view, I can expect the practical impact of this be about 0~ :P
Comment Actions
What I really like about math is that sum of changes with zero impact i never zero :D