Reduce string objects
ClosedPublic

Authored by tcanabrava on Jan 28 2019, 11:00 AM.

Details

Summary

QStringLiteral cannot deal with duplicates, so each invokation in
the same file with the same string will create a different UTF-16
string representation for that thing. Considering that we called
the same string six times in the same function, just create a temporary
variable that's the UTF-16 representation of the QString, and use it

Diff Detail

Repository
R106 KSysguard
Branch
reduceStrings
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 7617
Build 7635: arc lint + arc unit
tcanabrava created this revision.Jan 28 2019, 11:00 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 28 2019, 11:00 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
tcanabrava requested review of this revision.Jan 28 2019, 11:00 AM
apol accepted this revision.Jan 29 2019, 5:37 PM
apol added a subscriber: apol.

Looks okay from a theoretical point of view, I can expect the practical impact of this be about 0~ :P

This revision is now accepted and ready to land.Jan 29 2019, 5:37 PM
In D18578#401842, @apol wrote:

Looks okay from a theoretical point of view, I can expect the practical impact of this be about 0~ :P

What I really like about math is that sum of changes with zero impact i never zero :D

This revision was automatically updated to reflect the committed changes.