Make sure we don't offer overrides outside of a class declaration
ClosedPublic
Actions

Authored by apol on Jun 13 2016, 10:16 PM.

Details

Reviewers

Group Reviewers

Commits

Summary

Don't jump to the semantic parent (class declaration) but the lexical,
the top context, in the unit test semantics.

Repository

R32 KDevelop

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

apol retitled this revision from to Make sure we don't offer overrides outside of a class declaration.

apol updated this object.

apol added a reviewer: KDevelop.

if the new test passes and the existing tests also keep on running, then +2

thanks, the patch makes sense :)

This revision is now accepted and ready to land.Jun 14 2016, 11:11 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			languages/clang/codecompletion/completionhelper.cpp (2 lines)
M			languages/clang/tests/test_codecompletion.cpp (12 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	4424	a4aa5d6		Jun 13 2016, 10:16 PM	★	★
Diff 2	4446	a4aa5d6	rKDEVELOPe29c5c4da635339f6ff3070101ea5a337c7d3759	Jun 13 2016, 10:15 PM	★	★