Use task instead of note for AkonadiStorageTestBase::shouldNotifyItemRemoved
ClosedPublic
Actions

Authored by dfaure on Jan 25 2019, 9:59 PM.

Details

Reviewers

ervin

Commits

Summary

The notes collection is no longer accessible from this code

Test Plan

AkonadiStorageTest went from 6 failures to 5.

Repository

R4 Zanshin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

dfaure requested review of this revision.Jan 25 2019, 9:59 PM

dfaure created this revision.

dfaure set the repository for this revision to R4 Zanshin.Jan 25 2019, 10:00 PM

Slightly torn about that one since we stop checking that we won't die on other data types... But I guess that's a necessary evil for now.

This revision is now accepted and ready to land.Jan 29 2019, 8:22 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			tests/testlib/akonadistoragetestbase.cpp (7 lines)
M			tests/units/akonadi/testenv/data/testdata.xml (20 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	50297	a8d69cb		Jan 25 2019, 9:59 PM	★	★
Diff 2	50531	a6a3f19	R4:6b8eb4e6444301df3c4eb28780960c5ee0cf1800	Jan 29 2019, 10:28 PM	★	★