Differential D18525

Only force G and M codes toUpper
ClosedPublic
Actions

Authored by rizzitello on Jan 25 2019, 2:24 PM.

Details

Reviewers
tcanabrava
patrickelectric
laysrodrigues
Commits
R232:032ead64bfa7: Only force G and M codes toUpper https://reprap.org/wiki/G-code#Case_sensitivity
R232:ce753fb49d19: Only force G and M codes toUpper
Summary
Users need to enter some case sensitive info such as wifi passwords 
   Spec (https://reprap.org/wiki/G-code#Case_sensitivity) 
Internally AtCore does not force case since our GCode object sends them back correctly. 
Allow users to input case sensitive text into command widget but force G and M codes toUpper.

Diff Detail

Repository
R232 AtCore
Branch
caseInsensitive
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 7511
Build 7529: arc lint + arc unit
rizzitello requested review of this revision.Jan 25 2019, 2:24 PM
rizzitello created this revision.
rizzitello added reviewers: tcanabrava, patrickelectric, laysrodrigues.Jan 25 2019, 2:25 PM
rizzitello added a project: Atelier: AtCore.
rizzitello edited the summary of this revision. (Show Details)
rizzitello added a subscriber: Atelier: AtCore.
rizzitello edited the summary of this revision. (Show Details)Jan 25 2019, 2:28 PM
tcanabrava accepted this revision.Jan 25 2019, 3:23 PM
This revision is now accepted and ready to land.Jan 25 2019, 3:23 PM
patrickelectric accepted this revision.Jan 26 2019, 4:59 PM
rizzitello closed this revision.Jan 27 2019, 1:41 AM

Revision Contents
Changeset List

Diff 50258

View Options

src/core/gcodecommands.cpp

Loading...
View Options

src/widgets/commandwidget.cpp

Loading...
View Options

testclient/mainwindow.cpp

Loading...