The button effectively saves the theme to be edited as a new file, so turn it into a "Save As" button that is always shown.
- Group Reviewers
- R119:cc63a8af3913: [KColorSchemeEditor] Turn Save button into Save As
Editing a system color scheme that you cannot overwrite
Editing a user color scheme, "Save As" allows to save it as a new theme, Apply just applies the changes to the edited theme
The Apply button is only shown when the --overwrite option is passed to kcolorscheme, passed by the KCM for user themes. I just figured, perhaps it makes more sense to check file permissions (it only does that once you actually hit Save) and show the Apply button based on that
There's a somewhat awkward-feeling workflow here:
- Edit a system color scheme
- Click Save as... and save it as something else
The config dialog remains open, but suddenly is showing the copy, not the original. However it does not show the Apply button.
I think either the window should close after the Save As... Operation, or it should update its buttons accordingly.
I guess the way that the new theme is created through the ui is also something to consider. Maybe, let's think of a cleaner theme editing process and then the save button will be easier to understand?