[KColorSchemeEditor] Turn Save button into Save As

Authored by broulik on Jan 25 2019, 11:49 AM.



The button effectively saves the theme to be edited as a new file, so turn it into a "Save As" button that is always shown.

Test Plan

Editing a system color scheme that you cannot overwrite

Editing a user color scheme, "Save As" allows to save it as a new theme, Apply just applies the changes to the edited theme

The Apply button is only shown when the --overwrite option is passed to kcolorscheme, passed by the KCM for user themes. I just figured, perhaps it makes more sense to check file permissions (it only does that once you actually hit Save) and show the Apply button based on that

Diff Detail

R119 Plasma Desktop
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jan 25 2019, 11:49 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 25 2019, 11:49 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jan 25 2019, 11:49 AM

There's a somewhat awkward-feeling workflow here:

  1. Edit a system color scheme
  2. Click Save as... and save it as something else

The config dialog remains open, but suddenly is showing the copy, not the original. However it does not show the Apply button.

I think either the window should close after the Save As... Operation, or it should update its buttons accordingly.

abetts added a subscriber: abetts.Jan 27 2019, 9:48 PM

I guess the way that the new theme is created through the ui is also something to consider. Maybe, let's think of a cleaner theme editing process and then the save button will be easier to understand?

This revision was not accepted when it landed; it landed in state Needs Review.May 9 2019, 9:48 AM
This revision was automatically updated to reflect the committed changes.