[Desktop Theme KCM] Support installing from remote locations
ClosedPublic
Actions

Authored by broulik on Jan 24 2019, 1:58 PM.

Details

Reviewers

davidedmundson

Group Reviewers

Plasma

Commits

Summary

Uses KIO to copy the file into temp folder for installation.
The same as the other KCMs do.

Test Plan

Dragged a theme .tar.gz file from an sftp://-URL into the KCM which spawned a download and had the theme installed

Repository

R119 Plasma Desktop

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

Fix copy paste error

Given how much is copy pasta, is there anything that can be made into a lib / put in kpackagetool?

This revision is now accepted and ready to land.Jan 24 2019, 2:05 PM

The other KCMs don't use kpackagetool, so not sure how much sense it makes to add this to kpackagetool.

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			kcms/desktoptheme/CMakeLists.txt (2 lines)
M			kcms/desktoptheme/kcm.h (19 lines)
M			kcms/desktoptheme/kcm.cpp (50 lines)
M			kcms/desktoptheme/package/contents/ui/main.qml (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	50186			Jan 24 2019, 1:57 PM	★	★
Diff 2	50187			Jan 24 2019, 1:59 PM	★	★
Diff 3	50191	b52c0ce	R119:12f4d353f680876466f02f7a926d4c15793e9b60	Jan 24 2019, 2:07 PM	★	★