Useful error output when shell loading is aborted due to kactivitymanagerd not being activatable
ClosedPublic

Authored by hein on Jan 24 2019, 8:30 AM.

Details

Summary

Ran into this gotcha the other day, and it was impossible to resolve
without code debugging.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
hein created this revision.Jan 24 2019, 8:30 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 24 2019, 8:30 AM
hein requested review of this revision.Jan 24 2019, 8:30 AM
bshah accepted this revision as: bshah.Jan 24 2019, 8:32 AM

LGTM. Best wait for others to chime-in also though :)

This revision is now accepted and ready to land.Jan 24 2019, 8:32 AM
broulik added inline comments.
shell/shellcorona.cpp
649

qFatal calls abort so the second one can not be reached, can it? Perhaps just \n

hein updated this revision to Diff 50167.Jan 24 2019, 8:37 AM

Switch to qWarning().

broulik accepted this revision.Jan 24 2019, 8:38 AM
bshah added inline comments.Jan 24 2019, 8:39 AM
shell/shellcorona.cpp
319

On 2nd thought

qFatal is probably wrong, it is entirely possible that service is starting up and ::status is different then running, we might end up hitting needless abort?

hein added inline comments.Jan 24 2019, 8:40 AM
shell/shellcorona.cpp
319

Came to the same conclusion and switched to qWarning() already as per above.

649

The more I think about it, I think qFatal() might be wrong anyway. It changes behavior of the program, since in theory load() could be re-entered at a later time when kactivitymanagerd has since come up. I'll go with qWarning. Will update this diff.

hein added a comment.EditedJan 24 2019, 8:41 AM

Sorry @bshah, I wrote my comment in response to Kai before yours but forgot to submit.

bshah accepted this revision.Jan 24 2019, 8:43 AM

Yeah so since end result is same, +1

davidedmundson accepted this revision.Jan 24 2019, 11:46 AM
This revision was automatically updated to reflect the committed changes.