Ran into this gotcha the other day, and it was impossible to resolve
without code debugging.
Details
Details
Diff Detail
Diff Detail
- Repository
- R120 Plasma Workspace
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 7473 Build 7491: arc lint + arc unit
| shell/shellcorona.cpp | ||
|---|---|---|
| 649 | qFatal calls abort so the second one can not be reached, can it? Perhaps just \n | |
| shell/shellcorona.cpp | ||
|---|---|---|
| 319 | On 2nd thought qFatal is probably wrong, it is entirely possible that service is starting up and ::status is different then running, we might end up hitting needless abort? | |
| shell/shellcorona.cpp | ||
|---|---|---|
| 319 | Came to the same conclusion and switched to qWarning() already as per above. | |
| 649 | The more I think about it, I think qFatal() might be wrong anyway. It changes behavior of the program, since in theory load() could be re-entered at a later time when kactivitymanagerd has since come up. I'll go with qWarning. Will update this diff. | |
Comment Actions
Sorry @bshah, I wrote my comment in response to Kai before yours but forgot to submit.