Differential D18489

warnings--
ClosedPublic
Actions

Authored by davidedmundson on Jan 24 2019, 1:22 AM.

Details

Reviewers

apol

Group Reviewers

Plasma

Commits

R124:6c40ed4c42ab: warnings--

Summary

KAboutData::setProgramIconName isn't used in the AboutData dialog box,
instead the generic QApplication icon name is used.

Therefore there's little point setting it. It was also used by classic
mode to create an icon in the config page that it has, but we can do
that directly.

Test Plan

Compiles
Looked at module about data
Looked at settings page

Diff Detail

Repository

R124 System Settings

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 7468
Build 7486: arc lint + arc unit

davidedmundson created this revision.Jan 24 2019, 1:22 AM

Restricted Application added a project: Plasma. · View Herald TranscriptJan 24 2019, 1:22 AM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

davidedmundson requested review of this revision.Jan 24 2019, 1:22 AM

Harbormaster completed remote builds in B7468: Diff 50158.Jan 24 2019, 1:22 AM

apol accepted this revision.Jan 27 2019, 4:34 AM

This revision is now accepted and ready to land.Jan 27 2019, 4:34 AM

Closed by commit R124:6c40ed4c42ab: warnings-- (authored by davidedmundson). · Explain WhyJan 28 2019, 9:46 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			classic/CategoryList.cpp (1 line)
M			classic/ClassicMode.cpp (3 lines)
M			core/ModuleView.cpp (6 lines)
M			icons/IconMode.cpp (1 line)
M			sidebar/SidebarDelegate.cpp (1 line)
M			sidebar/SidebarMode.cpp (1 line)