Apply -Wno-inconsistent-missing-override for all compilers
ClosedPublic
Actions

Authored by davidedmundson on Jan 23 2019, 9:16 PM.

Details

Reviewers

graesslin

Group Reviewers

KWin

Commits

Summary

Default CXX flags are out of our control. Whether they're set by the
compiler or the user or ECM.

We currently disable for clang. This patch also disables this warning
for other compilers.

This might not be anyone's first preference, but we're at an impasse
there.

Test Plan

Compiled

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a project: KWin. · View Herald TranscriptJan 23 2019, 9:16 PM

Restricted Application added a subscriber: kwin. · View Herald Transcript

davidedmundson requested review of this revision.Jan 23 2019, 9:16 PM

The warnings are still present. Can't we just run clang-tidy to fix them?

Can't we just run clang-tidy to fix them?

That would be my preferred option.

This revision is now accepted and ready to land.Jan 24 2019, 7:26 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			CMakeLists.txt (6 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	50144	7ddd5af		Jan 23 2019, 9:16 PM	★	★
Diff 2	50200	4f69dc6	R108:a088a7b1a48295456b01f773c67d2428c98ddb12	Jan 24 2019, 4:28 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
4cee70266746	146de2d53156	7ddd5afe6442	David Edmundson	Apply -Wno-inconsistent-missing-override for all compilers (Show More…)	Jan 23 2019, 9:15 PM