Differential D18484

Unit Tests for Plugin Importer
ClosedPublic
Actions

Authored by rbreu on Jan 23 2019, 7:08 PM.

Details

Reviewers
rempt
Group Reviewers
Krita
Summary

It's a bit unfortunate that the first unit tests are this messy zip stuff, in case people want to look at examples. Makes the basics of the unittest frame work look more complicated than it is. ;)

Test Plan

Instructions for running unit tests here

Diff Detail

Repository
R37 Krita
Lint
Lint Skipped
Unit
Unit Tests Skipped
rbreu created this revision.Jan 23 2019, 7:08 PM
Restricted Application added a reviewer: Krita. · View Herald TranscriptJan 23 2019, 7:08 PM
Restricted Application added a project: Krita. · View Herald Transcript
rbreu requested review of this revision.Jan 23 2019, 7:08 PM
rempt added a subscriber: rempt.Jan 24 2019, 9:19 AM

Aye... It does look complicated. I haven't had time to play with it yet, I'm afraid.

rbreu added a comment.Jan 24 2019, 5:35 PM

You know, I should probably add some comments.

rbreu updated this revision to Diff 50255.Jan 25 2019, 2:16 PM

Added comments.

The interesting stuff is happening in tests/test_plugin_importer.py. The rest is just sample plugins for the various tests.

rempt accepted this revision.Jan 26 2019, 9:42 AM
This revision is now accepted and ready to land.Jan 26 2019, 9:42 AM
rbreu closed this revision.Jan 27 2019, 10:16 AM

Revision Contents
Changeset List

PathPackages
Mplugins/python/plugin_importer/plugin_importer.py (3 lines)
AMplugins/python/plugin_importer/tests/fixtures/fail_missing_keys_desktop_file/plugin/foo.action (19 lines)
AMplugins/python/plugin_importer/tests/fixtures/fail_missing_keys_desktop_file/plugin/foo.desktop (5 lines)
AMplugins/python/plugin_importer/tests/fixtures/fail_missing_keys_desktop_file/plugin/foo/__init__.py (1 line)
AMplugins/python/plugin_importer/tests/fixtures/fail_missing_keys_desktop_file/plugin/foo/foo.py (1 line)
AMplugins/python/plugin_importer/tests/fixtures/fail_no_desktop_file/plugin/foo.action (19 lines)
AMplugins/python/plugin_importer/tests/fixtures/fail_no_desktop_file/plugin/foo/__init__.py (1 line)
AMplugins/python/plugin_importer/tests/fixtures/fail_no_desktop_file/plugin/foo/foo.py (1 line)
AMplugins/python/plugin_importer/tests/fixtures/fail_no_init_file/plugin/foo.action (19 lines)
AMplugins/python/plugin_importer/tests/fixtures/fail_no_init_file/plugin/foo.desktop (6 lines)
AMplugins/python/plugin_importer/tests/fixtures/fail_no_init_file/plugin/foo/foo.py (1 line)
AMplugins/python/plugin_importer/tests/fixtures/fail_no_matching_plugindir/plugin/foo.action (19 lines)
AMplugins/python/plugin_importer/tests/fixtures/fail_no_matching_plugindir/plugin/foo.desktop (6 lines)
AMplugins/python/plugin_importer/tests/fixtures/fail_no_matching_plugindir/plugin/foo/__init__.py (1 line)
AMplugins/python/plugin_importer/tests/fixtures/fail_no_matching_plugindir/plugin/foo/foo.py (1 line)
AMplugins/python/plugin_importer/tests/fixtures/fail_unparsable_action_file/plugin/foo.action (1 line)
AMplugins/python/plugin_importer/tests/fixtures/fail_unparsable_action_file/plugin/foo.desktop (6 lines)
AMplugins/python/plugin_importer/tests/fixtures/fail_unparsable_action_file/plugin/foo/__init__.py (1 line)
AMplugins/python/plugin_importer/tests/fixtures/fail_unparsable_action_file/plugin/foo/foo.py (1 line)
AMplugins/python/plugin_importer/tests/fixtures/fail_unparsable_desktop_file/plugin/foo.action (19 lines)
AMplugins/python/plugin_importer/tests/fixtures/fail_unparsable_desktop_file/plugin/foo.desktop (1 line)
AMplugins/python/plugin_importer/tests/fixtures/fail_unparsable_desktop_file/plugin/foo/__init__.py (1 line)
AMplugins/python/plugin_importer/tests/fixtures/fail_unparsable_desktop_file/plugin/foo/foo.py (1 line)
AMplugins/python/plugin_importer/tests/fixtures/success_nested/plugin/foo.action (19 lines)
AMplugins/python/plugin_importer/tests/fixtures/success_nested/plugin/foo.desktop (6 lines)
AMplugins/python/plugin_importer/tests/fixtures/success_nested/plugin/somedir/foo/__init__.py (1 line)
AMplugins/python/plugin_importer/tests/fixtures/success_nested/plugin/somedir/foo/foo.py (1 line)
AMplugins/python/plugin_importer/tests/fixtures/success_no_action/plugin/foo.desktop (6 lines)
AMplugins/python/plugin_importer/tests/fixtures/success_no_action/plugin/foo/__init__.py (1 line)
AMplugins/python/plugin_importer/tests/fixtures/success_no_action/plugin/foo/foo.py (1 line)
AMplugins/python/plugin_importer/tests/fixtures/success_simple/plugin/foo.action (19 lines)
AMplugins/python/plugin_importer/tests/fixtures/success_simple/plugin/foo.desktop (6 lines)
AMplugins/python/plugin_importer/tests/fixtures/success_simple/plugin/foo/__init__.py (1 line)
AMplugins/python/plugin_importer/tests/fixtures/success_simple/plugin/foo/foo.py (1 line)
AMplugins/python/plugin_importer/tests/fixtures/success_toplevel/foo.action (19 lines)
AMplugins/python/plugin_importer/tests/fixtures/success_toplevel/foo.desktop (6 lines)
AMplugins/python/plugin_importer/tests/fixtures/success_toplevel/foo/__init__.py (1 line)
AMplugins/python/plugin_importer/tests/fixtures/success_toplevel/foo/foo.py (1 line)
Mplugins/python/plugin_importer/tests/test_plugin_importer.py (273 lines)

Diff 50255

View Options

plugins/python/plugin_importer/plugin_importer.py

Loading...
View Options

plugins/python/plugin_importer/tests/fixtures/fail_missing_keys_desktop_file/plugin/foo.action

Loading...
View Options

plugins/python/plugin_importer/tests/fixtures/fail_missing_keys_desktop_file/plugin/foo.desktop

Loading...
View Options

plugins/python/plugin_importer/tests/fixtures/fail_missing_keys_desktop_file/plugin/foo/__init__.py

Loading...
View Options

plugins/python/plugin_importer/tests/fixtures/fail_missing_keys_desktop_file/plugin/foo/foo.py

Loading...
View Options

plugins/python/plugin_importer/tests/fixtures/fail_no_desktop_file/plugin/foo.action

Loading...
View Options

plugins/python/plugin_importer/tests/fixtures/fail_no_desktop_file/plugin/foo/__init__.py

Loading...
View Options

plugins/python/plugin_importer/tests/fixtures/fail_no_desktop_file/plugin/foo/foo.py

Loading...
View Options

plugins/python/plugin_importer/tests/fixtures/fail_no_init_file/plugin/foo.action

Loading...
View Options

plugins/python/plugin_importer/tests/fixtures/fail_no_init_file/plugin/foo.desktop

Loading...
View Options

plugins/python/plugin_importer/tests/fixtures/fail_no_init_file/plugin/foo/foo.py

Loading...
View Options

plugins/python/plugin_importer/tests/fixtures/fail_no_matching_plugindir/plugin/foo.action

Loading...
View Options

plugins/python/plugin_importer/tests/fixtures/fail_no_matching_plugindir/plugin/foo.desktop

Loading...
View Options

plugins/python/plugin_importer/tests/fixtures/fail_no_matching_plugindir/plugin/foo/__init__.py

Loading...
View Options

plugins/python/plugin_importer/tests/fixtures/fail_no_matching_plugindir/plugin/foo/foo.py

Loading...
View Options

plugins/python/plugin_importer/tests/fixtures/fail_unparsable_action_file/plugin/foo.action

Loading...
View Options

plugins/python/plugin_importer/tests/fixtures/fail_unparsable_action_file/plugin/foo.desktop

Loading...
View Options

plugins/python/plugin_importer/tests/fixtures/fail_unparsable_action_file/plugin/foo/__init__.py

Loading...
View Options

plugins/python/plugin_importer/tests/fixtures/fail_unparsable_action_file/plugin/foo/foo.py

Loading...
View Options

plugins/python/plugin_importer/tests/fixtures/fail_unparsable_desktop_file/plugin/foo.action

Loading...
View Options

plugins/python/plugin_importer/tests/fixtures/fail_unparsable_desktop_file/plugin/foo.desktop

Loading...
View Options

plugins/python/plugin_importer/tests/fixtures/fail_unparsable_desktop_file/plugin/foo/__init__.py

Loading...
View Options

plugins/python/plugin_importer/tests/fixtures/fail_unparsable_desktop_file/plugin/foo/foo.py

Loading...
View Options

plugins/python/plugin_importer/tests/fixtures/success_nested/plugin/foo.action

Loading...
View Options

plugins/python/plugin_importer/tests/fixtures/success_nested/plugin/foo.desktop

Loading...
View Options

plugins/python/plugin_importer/tests/fixtures/success_nested/plugin/somedir/foo/__init__.py

Loading...
View Options

plugins/python/plugin_importer/tests/fixtures/success_nested/plugin/somedir/foo/foo.py

Loading...
View Options

plugins/python/plugin_importer/tests/fixtures/success_no_action/plugin/foo.desktop

Loading...
View Options

plugins/python/plugin_importer/tests/fixtures/success_no_action/plugin/foo/__init__.py

Loading...
View Options

plugins/python/plugin_importer/tests/fixtures/success_no_action/plugin/foo/foo.py

Loading...
View Options

plugins/python/plugin_importer/tests/fixtures/success_simple/plugin/foo.action

Loading...
View Options

plugins/python/plugin_importer/tests/fixtures/success_simple/plugin/foo.desktop

Loading...
View Options

plugins/python/plugin_importer/tests/fixtures/success_simple/plugin/foo/__init__.py

Loading...
View Options

plugins/python/plugin_importer/tests/fixtures/success_simple/plugin/foo/foo.py

Loading...
View Options

plugins/python/plugin_importer/tests/fixtures/success_toplevel/foo.action

Loading...
View Options

plugins/python/plugin_importer/tests/fixtures/success_toplevel/foo.desktop

Loading...
View Options

plugins/python/plugin_importer/tests/fixtures/success_toplevel/foo/__init__.py

Loading...
View Options

plugins/python/plugin_importer/tests/fixtures/success_toplevel/foo/foo.py

Loading...
View Options

plugins/python/plugin_importer/tests/test_plugin_importer.py

Loading...