I don't think that's the right way to fix the problem.

Do you have OpenGL ES 3.2?

Also, it looks like we don't create debug context.

In D18460#398165, @zzag wrote:

Also, it looks like we don't create debug context.

Do we need a debug context to query GL_CONTEXT_FLAGS?

In D18460#398295, @garg wrote:

Do we need a debug context to query GL_CONTEXT_FLAGS?

No.

In D18460#398164, @zzag wrote:

I don't think that's the right way to fix the problem.

Do you have OpenGL ES 3.2?

Yes, I have a strong suspicion that the Mali GLES implementation does not support querying that flag even though it advertises v3.2. I'm waiting on hearing back on this, but I also don't see a issue with adding what is essentially better error checking in our code?

In D18460#398297, @garg wrote:

Yes, I have a strong suspicion that the Mali GLES implementation does not support querying that flag even though it advertises v3.2. I'm waiting on hearing back on this, but I also don't see a issue with adding what is essentially better error checking in our code?

The problem I see with it is that we're working around one specific GLES implementation. Given that querying context flags was introduced in 3.2, this should be discussed first with folks that develop the Mali GLES implementation.

Keep in mind that the Nvidia driver triggered endless loops in checkglerror.

The nvidia thing is with glGetError
checkglerror is in our code which handles that case.

I've heard back from Mali upstream and this particular bug has been fixed in r20 of their blob, and I'm pushing Rockchip to get that driver released. I'm still of the opinion that adding the error check is a good idea though. Any thoughts?

In D18460#402510, @garg wrote:

... adding the error check is a good idea though.

No, it's not.