Add Appinfo metadata file
Details
- Reviewers
mak sebas - Group Reviewers
VDG Plasma - Commits
- R119:4c07484a8637: Add Appinfo metadata file
build and install
Diff Detail
- Repository
- R119 Plasma Desktop
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
plasma-desktop.metainfo.xml | ||
---|---|---|
11 ↗ | (On Diff #4391) | This is wrong, no? there is no plasma-desktop binary anymore? or you mean package name? |
No such option in metadata XML files it seems
https://techbase.kde.org/MetaInfo/Components
Well, even plasmashell is not provided by this :-D should go to plasma-workspace probably
Normally I would say "yes", but since this is a so-called generic component, which means that it will be possible to search for it with cli tools and install it easily e.g. via "appstreamcli install <id>`, but it will generally not be visible in tools like Discover.
This is because installing a complete DE is usually seen to be a bad idea.
So, adding screenshots won't hurt, but they won't be as visible as type=desktop component ones.
Btw, having a generic name of Plasma means one can write metainfo files for Plasmoids (which would sett "<extends>org.kde.plasmashell</>" in their metainfo file), meaning Plasma would be able to search for Plasmoids in a distro-agnostic way, so this is a great addition.
CMakeLists.txt | ||
---|---|---|
158 | This should be ${SHARE_INSTALL_PREFIX}/metainfo/, the "appdata" path is the legacy location. | |
plasma-desktop.metainfo.xml | ||
3 ↗ | (On Diff #4391) | This should ideally be a reverse-domain-name, to fit the general style of AppStream unique IDs. |
11 ↗ | (On Diff #4391) | Jup, the binary name would be plasmashell. But you could omit this data block entirely, unless you want people to be able to search for the AppStream component when they know the binary name. |
plasma-desktop.metainfo.xml | ||
---|---|---|
16 ↗ | (On Diff #4394) | FWIW, you can omit width and height here - the AppStream generators won't trust that information in metainfo files anyway and just fetch the screenshot and update the data accordingly. |
3 ↗ | (On Diff #4391) | oh, and if this is changed, renaming the metainfo file is a useful thing to do (-> "org.kde.plasmashell.metainfo.xml") |
CMakeLists.txt | ||
---|---|---|
158 | I might be wrong with that, but shouldn't METAINFODIR be CMAKE_INSTALL_METAINFODIR (or KDE_INSTALL_* for that matter?) | |
org.kde.plasmashell.metainfo.xml | ||
17 | You could even drop the type=source property here, but having it also doesn't hurt. |
org.kde.plasmashell.metainfo.xml | ||
---|---|---|
4 | Btw, a "metadata_license" tag with a permissive license (CC0/MIT) needs to be added too, so we are sure that we can reuse the metadata downstream easily. |