Differential D18430

[DesktopView] Don't set a window icon
ClosedPublic
Actions

Authored by broulik on Jan 21 2019, 4:29 PM.

Details

Reviewers
mart
davidedmundson
Group Reviewers
Plasma
Commits
R120:60d56d880302: [DesktopView] Don't set a window icon
Summary

The desktop view isn't visible in the task bar, tabbox, and neither does it have a window decoration.

Test Plan

Saves some RAM and startup time.
QWindow::setIcon in this case was 1.63% on startup, mostly caused by icon theme setup stuff, so the impact isn't as noticeable overall.
Verified in xprop that the icon was gone.
Plasma popups that show up in tabbox are unaffected and still have an icon.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Jan 21 2019, 4:29 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 21 2019, 4:29 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jan 21 2019, 4:29 PM
broulik edited the test plan for this revision. (Show Details)
mart accepted this revision.Jan 22 2019, 2:26 PM
This revision is now accepted and ready to land.Jan 22 2019, 2:26 PM
davidedmundson accepted this revision.Jan 22 2019, 2:30 PM
Closed by commit R120:60d56d880302: [DesktopView] Don't set a window icon (authored by broulik). · Explain WhyJan 22 2019, 2:55 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mshell/desktopview.cpp (1 line)

Diff 49997

View Options

shell/desktopview.cpp

Loading...