Differential D18400

Use new toolbox icon for "Tools" dropdown menu button
ClosedPublic
Actions

Authored by ngraham on Jan 20 2019, 1:35 AM.

Details

Reviewers
ndavis
Group Reviewers
Spectacle
VDG
Commits
R166:9fe51427f193: Use new toolbox icon for "Tools" dropdown menu button
Summary

Use the awesome new tools icon in the Tools dropdown menu button. Since the icon is only available in Frameworks 5.55, we use the old icon as a fallback since the minimum frameworks version is still 5.29.

Test Plan

Diff Detail

Repository
R166 Spectacle
Branch
use-new-tools-icon (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 7334
Build 7352: arc lint + arc unit
ngraham created this revision.Jan 20 2019, 1:35 AM
Restricted Application added a project: Spectacle. · View Herald TranscriptJan 20 2019, 1:35 AM
ngraham requested review of this revision.Jan 20 2019, 1:35 AM
broulik added a subscriber: broulik.Jan 21 2019, 8:46 AM

You could also use a fallback chain:

QIcon::fromTheme(QStringLiteral("tools"), QIcon::fromTheme("application-menu"));

(second argument in QIcon::fromTheme is icon to be used if the theme icon wasn't found)

ngraham updated this revision to Diff 50033.Jan 21 2019, 11:21 PM

Set a fallback icon

ngraham updated this revision to Diff 50034.Jan 21 2019, 11:25 PM

Revert the CMake change since the icon fallback chain obviates the need for it

ngraham edited the summary of this revision. (Show Details)Jan 21 2019, 11:26 PM
ndavis accepted this revision.Jan 29 2019, 3:58 AM
This revision is now accepted and ready to land.Jan 29 2019, 3:58 AM
Closed by commit R166:9fe51427f193: Use new toolbox icon for "Tools" dropdown menu button (authored by ngraham). · Explain WhyJan 29 2019, 5:00 AM
This revision was automatically updated to reflect the committed changes.
ngraham added a comment.Jan 29 2019, 5:08 AM

Thanks! How about D18395?

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (2 lines)
Msrc/Gui/KSMainWindow.cpp (2 lines)

Diff 49912

View Options

CMakeLists.txt

Loading...
View Options

src/Gui/KSMainWindow.cpp

Loading...