Use new toolbox icon for "Tools" dropdown menu button
ClosedPublic

Authored by ngraham on Jan 20 2019, 1:35 AM.

Details

Summary

Use the awesome new tools icon in the Tools dropdown menu button. Since the icon is only available in Frameworks 5.55, we use the old icon as a fallback since the minimum frameworks version is still 5.29.

Test Plan

Diff Detail

Repository
R166 Spectacle
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Jan 20 2019, 1:35 AM
Restricted Application added a project: Spectacle. · View Herald TranscriptJan 20 2019, 1:35 AM
ngraham requested review of this revision.Jan 20 2019, 1:35 AM

You could also use a fallback chain:

QIcon::fromTheme(QStringLiteral("tools"), QIcon::fromTheme("application-menu"));

(second argument in QIcon::fromTheme is icon to be used if the theme icon wasn't found)

ngraham updated this revision to Diff 50033.Jan 21 2019, 11:21 PM

Set a fallback icon

ngraham updated this revision to Diff 50034.Jan 21 2019, 11:25 PM

Revert the CMake change since the icon fallback chain obviates the need for it

ngraham edited the summary of this revision. (Show Details)Jan 21 2019, 11:26 PM
ndavis accepted this revision.Jan 29 2019, 3:58 AM
This revision is now accepted and ready to land.Jan 29 2019, 3:58 AM
This revision was automatically updated to reflect the committed changes.

Thanks! How about D18395?