| davidedmundson |
| KWin |
The new connect syntax has several advantages over the old syntax:
(a) Connecting with the new syntax is faster;
(b) It is compile time checked.
There are still a few places where the old connect syntax is used, e.g.
connecting to QML buttons in the Desktop Grid effect.
Have been testing this patch for ~2 weeks, haven't noticed any
regressions.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
I know it's a huge patch, but I hope it would be okay to merge it. We have a big time frame to test the patch.
| effects/desktopgrid/desktopgrid_config.cpp | ||
|---|---|---|
| 89–91 | Do we allow C++14? | |
| effects/desktopgrid/desktopgrid_config.cpp | ||
|---|---|---|
| 89–91 | ||
... speaking of hand porting and human errors, I don't think it would be a good idea to use a script or something like that to port KWin to the new connect syntax because there are cases when we still want to use the old syntax.
Biggest issue I've seen with this connect porting is when people use slots as fake-virtuals.
Something to be wary of in the core, but in here it's all leaf classes.
Given Martin's happy too, go for it.
If you have:
Base
{
public Q_SLOTS:
void foo();
}
Derived
{
public Q_SLOTS:
void foo();
}asdf = new Derived();
connect(.., asdf, SLOT(foo())); goes to Derived
connect(..., asdf, &Base::foo); goes to Base