Differential D18358

Add buttons to collapse and expand all elements
ClosedPublic
Actions

Authored by joaonetto on Jan 18 2019, 1:04 PM.

Details

Reviewers
ngraham
aacid
Group Reviewers
Okular
VDG
Commits
R223:b66939840440: Add buttons to collapse and expand all elements
Summary

Adds two buttons on the bottom right to expand and collapse all elements in annotations
BUG: 377024
T8553

With latest breeze-icons:

Without it:

Diff Detail

Repository
R223 Okular
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
joaonetto created this revision.Jan 18 2019, 1:04 PM
Restricted Application added a project: Okular. · View Herald TranscriptJan 18 2019, 1:04 PM
Restricted Application added a subscriber: okular-devel. · View Herald Transcript
joaonetto requested review of this revision.Jan 18 2019, 1:04 PM
joaonetto retitled this revision from Add buttons to collapse and expand all elements to [WIP] Add buttons to collapse and expand all elements.Feb 13 2019, 11:44 PM
joaonetto edited the summary of this revision. (Show Details)
ngraham added a reviewer: Okular.Feb 14 2019, 4:43 AM
ngraham added a subscriber: ngraham.

If you need icons, please file a bug in the Breeze | Icons product and add VDG as a subscriber to the patch.

aacid added a subscriber: aacid.Mar 6 2019, 6:53 PM

Are we waiting for the new icons here? Any idea if they will be ever done or should we just go with something else?

ui/side_reviews.cpp
156

This should probably be Collapse instead of Collapses. Not sure that's very english-y. @ngraham does it sound right to you?

ngraham requested changes to this revision.Mar 6 2019, 8:06 PM

We're waiting for icons, but I just heard not 5 minutes ago that they're in progress, in fact.

ui/side_reviews.cpp
156

Right, that should definitely be "Collapse all elements".

This revision now requires changes to proceed.Mar 6 2019, 8:06 PM
joaonetto added a comment.Mar 6 2019, 8:25 PM
In D18358#426098, @ngraham wrote:

We're waiting for icons, but I just heard not 5 minutes ago that they're in progress, in fact.

That's some great news. I'll be waiting on it

ngraham added a comment.Mar 6 2019, 8:26 PM

Also please remove the [WIP] from the title since there's nothing here that's really WIP as far as I can tell; just a string change and waiting for icons.

joaonetto updated this revision to Diff 53762.Mar 12 2019, 10:53 PM
joaonetto marked 2 inline comments as done.

Updated with new icons, should use latest breeze-icons. Also fixed typo

joaonetto retitled this revision from [WIP] Add buttons to collapse and expand all elements to Add buttons to collapse and expand all elements.Mar 12 2019, 10:54 PM
joaonetto edited the summary of this revision. (Show Details)
aacid added a comment.Mar 12 2019, 11:08 PM

How does it look when you don't have latest breeze?

ndavis added a subscriber: ndavis.Mar 12 2019, 11:23 PM
In D18358#429972, @aacid wrote:

How does it look when you don't have latest breeze?

You wouldn't get any icons for "collapse/expand all" buttons without the latest breeze-icons.

joaonetto edited the summary of this revision. (Show Details)Mar 12 2019, 11:29 PM

Just added some screenshots with the results.

aacid accepted this revision.Mar 31 2019, 10:16 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 31 2019, 10:17 PM
Closed by commit R223:b66939840440: Add buttons to collapse and expand all elements (authored by joaonetto, committed by aacid). · Explain Why
This revision was automatically updated to reflect the committed changes.
davidhurka added a subscriber: davidhurka.May 25 2019, 12:15 PM
davidhurka added inline comments.
ui/side_reviews.cpp
156

Something is wrong with this icon, it does not change to a light foreground color at a dark theme.


It’s not because like it is disabled, it’s always that dark.

Revision Contents
Changeset List

PathPackages
Mui/side_reviews.h (2 lines)
Mui/side_reviews.cpp (20 lines)

Diff 55159

View Options

ui/side_reviews.h

Loading...
View Options

ui/side_reviews.cpp

Loading...