Differential D18356

[Plasma Theme] Use new connect syntax
ClosedPublic
Actions

Authored by broulik on Jan 18 2019, 11:31 AM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R242:8c5099140751: [Plasma Theme] Use new connect syntax
Summary

Saves some cycles

Test Plan

Saves like 0.6ms on startup here, given the amount of Theme objects created.
ThemePrivate is also a QObject, I don't understand why it checks for qApp or why it's not done in the Private's constructor though..

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jan 18 2019, 11:31 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 18 2019, 11:31 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
broulik requested review of this revision.Jan 18 2019, 11:31 AM
davidedmundson accepted this revision.Jan 18 2019, 11:33 AM
This revision is now accepted and ready to land.Jan 18 2019, 11:33 AM
Closed by commit R242:8c5099140751: [Plasma Theme] Use new connect syntax (authored by broulik). · Explain WhyJan 18 2019, 11:34 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/plasma/theme.cpp (12 lines)

Diff 49805

View Options

src/plasma/theme.cpp

Loading...