Use QPointer for KNotification
Use ready signal for signalling updates
BUG: 400010
Details
Details
- Reviewers
broulik albertvaka - Group Reviewers
KDE Connect - Commits
- R224:74e7a90cd8d5: Simplify notification handling
R224:c2a663691b3d: Simplify notification handling
Spawned some notifications
Diff Detail
Diff Detail
- Repository
- R224 KDE Connect
- Branch
- noti
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 7271 Build 7289: arc lint + arc unit
| plugins/notifications/notification.cpp | ||
|---|---|---|
| 84 | Can't this be simplified to drop the update argument and just check for m_notification? This method is only used in the constructor where m_notification is null anyway, and in update where you check for m_notification | |
| 84 | Looks like it's "public API", so maybe not? | |
| plugins/notifications/notification.cpp | ||
|---|---|---|
| 84 | Good point. I actually think I can simplify things much more | |
| plugins/notifications/notification.cpp | ||
|---|---|---|
| 84 | Indeed, I think the m_closed stuff also isn't neccessary anymore | |