Add support for auto temperature reporting
ClosedPublic

Authored by rizzitello on Jan 18 2019, 4:52 AM.

Diff Detail

Repository
R232 AtCore
Branch
selectTempMethod
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 8164
Build 8182: arc lint + arc unit
rizzitello requested review of this revision.Jan 18 2019, 4:52 AM
rizzitello created this revision.
patrickelectric requested changes to this revision.Jan 19 2019, 12:39 PM
patrickelectric added inline comments.
testclient/mainwindow.cpp
659

would it be easier to do the if/else with value and 1000 ?

testclient/mainwindow.h
95

Need @param

This revision now requires changes to proceed.Jan 19 2019, 12:39 PM
rizzitello marked an inline comment as done.Jan 19 2019, 12:54 PM
  • Rebase
  • Add missing @param
patrickelectric requested changes to this revision.Jan 26 2019, 1:52 PM
patrickelectric added inline comments.
src/core/atcore.cpp
359

This should be after d->autoTemperatureReport = autoReport no ?

This revision now requires changes to proceed.Jan 26 2019, 1:52 PM
rizzitello updated this revision to Diff 50331.Jan 26 2019, 4:20 PM
rizzitello marked an inline comment as done.
  • set then emit
patrickelectric accepted this revision.Jan 27 2019, 11:46 PM
This revision is now accepted and ready to land.Jan 27 2019, 11:46 PM
rizzitello updated this revision to Diff 51262.Feb 9 2019, 3:29 PM
  • Cleaner logic
rizzitello updated this revision to Diff 51380.Feb 11 2019, 1:24 AM
  • Block emit of autodetect changed on Disconnect
laysrodrigues accepted this revision.Feb 11 2019, 5:17 PM
rizzitello closed this revision.Feb 11 2019, 5:32 PM