Fix DesktopGrid drag on X11
ClosedPublic

Authored by davidedmundson on Jan 17 2019, 9:57 PM.

Details

Summary

EffectsAPI explicitly says:
"On X11, the window will end up on the last window in the list" and
DesktopGrid reliaed on that.

Using the last makes sense as it means the
enterDesktop method will work for both.

Somehow in the refactors AbstractClient ended up doing the opposite.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Jan 17 2019, 9:57 PM
Restricted Application added a project: KWin. · View Herald TranscriptJan 17 2019, 9:57 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
davidedmundson requested review of this revision.Jan 17 2019, 9:57 PM
zzag added a subscriber: zzag.Jan 17 2019, 10:46 PM

When can a client end up on several desktops? (on X11)

abstract_client.h
437

**/ (for consistency)

When can a client end up on several desktops? (on X11)

It can't ultimately end up on multiple. This is the entry point for other parts of kwin to set the desktops and this is the line that reduces X down to 1.
You could make a case that DesktopGrid/whatever else should handle the abstraction and never request more than 1 but we still need to have a guard and we should still match the docs in EffectWindow.

zzag accepted this revision.Jan 17 2019, 11:32 PM
This revision is now accepted and ready to land.Jan 17 2019, 11:32 PM
This revision was automatically updated to reflect the committed changes.