Debugger plugin fixes

Authored by igorkushnir on Jan 17 2019, 5:04 PM.



Rename Qt logging category: common -> debuggercommon

The old name was too generic and undescriptive. This resulted in
the following confusing lines in KDevelop output:

kdevelop.plugins.common: Change session  QObject(0x0)
kdevelop.plugins.common: Will reparse arch

MIDebugger: print a specific process error message

Information in the messageboxes is general and sometimes insufficient
to understand why the process could not be started. In such cases
a warning-level error message can be useful. For example:

Debugger ERRORED QProcess::FailedToStart "execvp: Exec format error"
Debugger ERRORED QProcess::WriteError "Error writing to process"

GdbDebugger: pass correct string in userCommandOutput()

When Shell script was not empty, both the shell path and the debugger
executable were duplicated in the string sent to userCommandOutput()
because they are prepended to arguments in if(!shell.isEmpty()) branch.

Test Plan

Run test_gdb, test_gdbprinters, test_lldb and test_lldbformatters.
The number of failed and skipped tests did not change with these fixes.

Diff Detail

R32 KDevelop
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
igorkushnir created this revision.Jan 17 2019, 5:04 PM
Restricted Application added a project: KDevelop. · View Herald TranscriptJan 17 2019, 5:04 PM
Restricted Application added a subscriber: kdevelop-devel. · View Herald Transcript
igorkushnir requested review of this revision.Jan 17 2019, 5:04 PM
mwolff accepted this revision.Jan 26 2019, 11:12 PM
mwolff added a subscriber: mwolff.

lgtm, thanks. note that you now need to push to the new gitlab remote ( cf. for future reviews

This revision is now accepted and ready to land.Jan 26 2019, 11:12 PM
This revision was automatically updated to reflect the committed changes.