Usually the application page is not the top level page (you'll usually navigate through it using one of the app lists), but when it is, this patch ensures that the search field is displayed, and further ensures that the search is performed on the full list of resources. This will happen when Discover is launched e.g. from krunner or otherwise requested to show a specific application on launch.
Details
Details
- Reviewers
apol ngraham - Group Reviewers
Discover Software Store - Commits
- R134:9aa0a7df1395: Search-enable the application page
R134:7a9f008ee7e6: Search-enable the application page
Diff Detail
Diff Detail
- Repository
- R134 Discover Software Store
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Thanks for the copious code comments. Definitely makes things easier to understand in the future.
Comment Actions
i do prefer to overcomment rather than undercomment... i've come back to things too many times and gone "huh, must be a reason" and then gone searching for ages to discover the reason which, of course, is never just straightforward - i want future-me to not squint disappointingly at past-me ;)
Comment Actions
Cherry-picked onto the Plasma/5.15 branch since it's a bugfix that doesn't introduce any string changes.
Let's try to land future patches that meet those criteria on the Plasma/5.15 branch during the 5.15 beta period. We need to polish Discover to a mirror sheen as much as possible! :)