Differential D18309

don't set python exe to undefined
ClosedPublic
Actions

Authored by sitter on Jan 17 2019, 7:44 AM.

Details

Reviewers
davidedmundson
fvogt
Commits
R98:51e27ecf4057: don't set python exe to undefined
Summary

FindPythonInterp sets PYTHON_EXECUTABLE, we overrode it by setting an
empty var. add a comment to explain the unbalancedness of the conditional
branches.

Test Plan

pythoncairo is correctly found with cmake 3.10.2

Diff Detail

Repository
R98 Breeze for Gtk
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter created this revision.Jan 17 2019, 7:44 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 17 2019, 7:44 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
sitter requested review of this revision.Jan 17 2019, 7:44 AM
heikobecker added a subscriber: heikobecker.Jan 17 2019, 7:52 AM

+1
I have no cmake < 3.12.0 to test, but the changes are reasonable.

sitter edited the test plan for this revision. (Show Details)Jan 17 2019, 7:57 AM
fvogt accepted this revision.Jan 17 2019, 8:11 AM
fvogt added a subscriber: fvogt.

Tested with cmake 3.10.2, works.

This revision is now accepted and ready to land.Jan 17 2019, 8:11 AM
Closed by commit R98:51e27ecf4057: don't set python exe to undefined (authored by sitter). · Explain WhyJan 17 2019, 10:20 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mcmake/FindPythonCairo.cmake (2 lines)

Diff 49700

View Options

cmake/FindPythonCairo.cmake

Loading...