[Greeter] Ignore unwritable configuration files
ClosedPublic

Authored by broulik on Jan 16 2019, 9:14 AM.

Details

Summary

When opening a non-writable config file, a kdialog process is spawned and the application waits for it to quit.
However, since in case of the lock screen, the input and everything is already blocked, the user cannot dismiss the warning generated by the greeter, effectively locking the user out.

BUG: 403255

Test Plan

Created a non-writable ~/.config/kscreenlocker_greetrc and locked the screen:
Greeter comes up as normal
kscreenlocker itself may need something similar?

I grepped kde source code for that environment variable and it only seems to be used for warning suppression, it doesn't disable writing or persisting configuration.

Diff Detail

Repository
R133 KScreenLocker
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jan 16 2019, 9:14 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 16 2019, 9:14 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jan 16 2019, 9:14 AM
davidedmundson accepted this revision.Jan 16 2019, 12:37 PM
This revision is now accepted and ready to land.Jan 16 2019, 12:37 PM
This revision was automatically updated to reflect the committed changes.