Fix KDE Connect volume control
ClosedPublic

Authored by nicolasfella on Jan 15 2019, 6:57 PM.

Details

Summary

I don't fully understand why it happens, but controlling the volume from KDE Connect was broken because of this check. It seems to work fine without it

Test Plan

Play around with volume sliders in KDE Connect. Add/remove sinks

Diff Detail

Repository
R994 Pulseaudio Qt Bindings
Branch
noglibcheck
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 7143
Build 7161: arc lint + arc unit
nicolasfella created this revision.Jan 15 2019, 6:57 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 15 2019, 6:57 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
nicolasfella requested review of this revision.Jan 15 2019, 6:57 PM
nicolasfella edited the summary of this revision. (Show Details)Jan 15 2019, 6:59 PM
nicolasfella edited the test plan for this revision. (Show Details)
nicolasfella added a reviewer: drosca.
drosca requested changes to this revision.Jan 15 2019, 7:30 PM

I think it would be better to edit the check only to contains("Glib") as it still makes sense to check for GLib event loop, as otherwise the code will just silently fail.

In older Qt versions, QAbstractEventDispatcher::instance() was QEventDispatcherGlib, it is now (at least on xcb platform) QXcbGlibEventDispatcher.

This revision now requires changes to proceed.Jan 15 2019, 7:30 PM
drosca accepted this revision.Jan 15 2019, 7:50 PM

Related patch to plasma-pa D16443

This revision is now accepted and ready to land.Jan 15 2019, 7:50 PM
This revision was automatically updated to reflect the committed changes.