diff --git a/CMakeLists.txt b/CMakeLists.txt --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -68,6 +68,11 @@ find_package(KF5 ${KF5_MIN_VERSION} OPTIONAL_COMPONENTS Activities ) +set_package_properties(KF5Activities PROPERTIES DESCRIPTION "KActivities libraries" + URL "http://www.kde.org" + TYPE OPTIONAL + PURPOSE "For tracking which folders are frequently accessed on a Plasma desktop" + ) find_package(Phonon4Qt5 CONFIG REQUIRED) @@ -91,6 +96,10 @@ PURPOSE "For accessing file metadata labels" ) +if (KF5Activities_FOUND) + set(HAVE_KACTIVITIES TRUE) +endif() + if (KF5Baloo_FOUND AND KF5BalooWidgets_FOUND AND KF5FileMetaData_FOUND) message(STATUS "Baloo packages are found") set(HAVE_BALOO TRUE) diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -2,7 +2,7 @@ configure_file(config-baloo.h.cmake ${CMAKE_CURRENT_BINARY_DIR}/config-baloo.h) -configure_file(config-dolphin.h.cmake ${CMAKE_CURRENT_BINARY_DIR}/config-dolphin.h) +configure_file(config-kactivities.h.cmake ${CMAKE_CURRENT_BINARY_DIR}/config-kactivities.h) add_definitions( -DTRANSLATION_DOMAIN=\"dolphin\" @@ -277,7 +277,7 @@ Phonon::phonon4qt5 ) -if (KF5Activities_FOUND) +if (HAVE_KACTIVITIES) target_link_libraries( dolphinstatic KF5::Activities diff --git a/src/config-dolphin.h.cmake b/src/config-dolphin.h.cmake deleted file mode 100644 --- a/src/config-dolphin.h.cmake +++ /dev/null @@ -1,4 +0,0 @@ - -/* Define to 1 if you have the KActivities library. */ -#cmakedefine KF5Activities_FOUND 1 - diff --git a/src/config-kactivities.h.cmake b/src/config-kactivities.h.cmake new file mode 100644 --- /dev/null +++ b/src/config-kactivities.h.cmake @@ -0,0 +1 @@ +#cmakedefine HAVE_KACTIVITIES diff --git a/src/dolphinviewcontainer.h b/src/dolphinviewcontainer.h --- a/src/dolphinviewcontainer.h +++ b/src/dolphinviewcontainer.h @@ -20,7 +20,7 @@ #ifndef DOLPHINVIEWCONTAINER_H #define DOLPHINVIEWCONTAINER_H -#include "config-dolphin.h" +#include "config-kactivities.h" #include "views/dolphinview.h" #include @@ -32,7 +32,7 @@ #include #include -#ifdef KF5Activities_FOUND +#ifdef HAVE_KACTIVITIES namespace KActivities { class ResourceInstance; } @@ -343,7 +343,7 @@ QElapsedTimer m_statusBarTimestamp; // Time in ms since last update bool m_autoGrabFocus; -#ifdef KF5Activities_FOUND +#ifdef HAVE_KACTIVITIES private: KActivities::ResourceInstance * m_activityResourceInstance; #endif diff --git a/src/dolphinviewcontainer.cpp b/src/dolphinviewcontainer.cpp --- a/src/dolphinviewcontainer.cpp +++ b/src/dolphinviewcontainer.cpp @@ -30,6 +30,9 @@ #include "views/viewmodecontroller.h" #include "views/viewproperties.h" +#ifdef HAVE_KACTIVITIES +#include +#endif #include #include #include @@ -63,8 +66,8 @@ m_statusBarTimer(nullptr), m_statusBarTimestamp(), m_autoGrabFocus(true) -#ifdef KActivities_FOUND - , m_activityResourceInstance(0) +#ifdef HAVE_KACTIVITIES + , m_activityResourceInstance(nullptr) #endif { hide(); @@ -221,11 +224,10 @@ // Initialize kactivities resource instance - #ifdef KActivities_FOUND - m_activityResourceInstance = new KActivities::ResourceInstance( - window()->winId(), url); +#ifdef HAVE_KACTIVITIES + m_activityResourceInstance = new KActivities::ResourceInstance(window()->winId(), url); m_activityResourceInstance->setParent(this); - #endif +#endif } DolphinViewContainer::~DolphinViewContainer() @@ -243,13 +245,13 @@ m_urlNavigator->setActive(active); m_view->setActive(active); - #ifdef KActivities_FOUND +#ifdef HAVE_KACTIVITIES if (active) { m_activityResourceInstance->notifyFocusedIn(); } else { m_activityResourceInstance->notifyFocusedOut(); } - #endif +#endif } bool DolphinViewContainer::isActive() const @@ -465,9 +467,9 @@ m_urlNavigator->setLocationUrl(newUrl); } - #ifdef KActivities_FOUND +#ifdef HAVE_KACTIVITIES m_activityResourceInstance->setUri(newUrl); - #endif +#endif } void DolphinViewContainer::setFilterBarVisible(bool visible)