[kcmkwin/kwindesktop] Fix error in desktop layout indicator initial state
ClosedPublic

Authored by davidedmundson on Jan 15 2019, 5:01 PM.

Details

Summary

kcm.osdTextOnly is the inverse of "show desktop layout indicators"

The save was inversed, the load was not.

Also port from onCheckedChanged to onToggled as that's emitted only on
user changes and not on binding re-evaluation.

BUG: 403150

Test Plan

Toggled it
Reopened KCM
Checked kwinrc

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Jan 15 2019, 5:01 PM
Restricted Application added a project: KWin. · View Herald TranscriptJan 15 2019, 5:01 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
davidedmundson requested review of this revision.Jan 15 2019, 5:01 PM
ngraham accepted this revision.Jan 15 2019, 5:26 PM
ngraham added a subscriber: ngraham.

Bug fixed, code is sane!

In case you're interested in other bugs found with the new VD KCM, here are the ones I'm aware of:

This revision is now accepted and ready to land.Jan 15 2019, 5:26 PM
This revision was automatically updated to reflect the committed changes.